Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new scikit-learn release breaks tests #1015

Closed
StrikerRUS opened this issue Oct 23, 2017 · 3 comments · Fixed by #1016
Closed

new scikit-learn release breaks tests #1015

StrikerRUS opened this issue Oct 23, 2017 · 3 comments · Fixed by #1016

Comments

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Oct 23, 2017

The new scikit-learn release 0.19.1 breaks our tests: https://ci.appveyor.com/project/guolinke/lightgbm/build/2.0.10.1064/job/fg7fvmf5v5shwbeq#L2151

At first sight from logs it seems to be that StratifiedKFold is the root of problems.

I have no free time today (tonight in my timezone), maybe @guolinke, @wxchan, @henry0312 can perform quickfix.

http://scikit-learn.org/stable/whats_new.html#version-0-19-1

@StrikerRUS
Copy link
Collaborator Author

The commit that brings this error: scikit-learn/scikit-learn@94fa697#diff-b127807ffe58ea714328428b780f0afb

@guolinke
Copy link
Collaborator

@StrikerRUS we need to change the target to int type in binary and multi classification ?

@StrikerRUS
Copy link
Collaborator Author

@guolinke I'm not sure, but it seems that in test_cv StratifiedKFold is used for the regression task (boston dataset).

@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants