-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Also create a lightgbm-gpu release #2263
Comments
When ever I get the feeling its time for a full fresh install of windows I come here and try to make installation of lightgbm with GPU on my Windows 10 machine happen.z You directions are almost as bad as having nothing -so I love the idea. Please make PilipMay and I happy |
Thanks for the suggestion, @PhilipMay ! I'm not sure we've explored that before, I will have to look into @PCJimmmy I am sorry you've had a poor experience with the documentation for using |
James
Two issues –
1. Not much you can do about this one but I have very little experience with the whole build process – as a simple Windows user all my life things that are very apparent to a Linux user are not so apparent to me. Building a wheel for Windows IMO should always have high value for any library – Windows users are dummies – we need one click installation. I am using the heck out of lightgbm these last weeks but if I had to build the darn thing it would have never been used.
2. Too many option paths for the Windows user in your directions – again not real clear what goes with what – pretend your starting from scratch and write a flow for your Windows PC on a piece of paper – lots of points on that flow were decisions need to be made – I am too stupid to accurately make them. There was a very nice example of how to build GPU version for Linux on Kaggle in Jupyter notebook. That at least did give me a little better idea of flow. How about instead of writing on piece of paper you create a notebook with the flow that would get GPU version installed. If I had a windows version of kernel than I could step thru and probably make the right decisions in the right order.
3. In adding all the pre-req’s to my PC (Visual Studio 2019, cmake, etc) the main issue seems to be that paths are present – so in the step where Cmake used for example, my pc does not see it (in command)
So – my suggestion – write an example notebook for Windows 10. I mean folks wanting to install lightgbm on a windows machine are 99% likely to be using Jupyter notebooks for their work.
Sent from Mail for Windows 10
From: James Lamb
Sent: Wednesday, July 17, 2019 1:09 AM
To: microsoft/LightGBM
Cc: PCJimmmy; Mention
Subject: Re: [microsoft/LightGBM] Suggestion: Also create a lightgbm-gpurelease (#2263)
Thanks for the suggestion, @PhilipMay ! I'm not sure we've explored that before, I will have to look into tensorflow-gpu. @huanzhang12 what do you think about this idea?
@PCJimmmy I am sorry you've had a poor experience with the documentation for using lightgbm with GPUs. In a separate issue, could you share some specific things you'd like to see changed or added in that documentation? Updating docs will probably happen before creating a new package, so we'd like to hear from you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
For For
Can you please provide a link? Then we can ask the author to replicate it here. |
Here is link to the Linux Kaggle kernel – I am PC Jimmmy on Kaggle
https://www.kaggle.com/vinhnguyen/gpu-acceleration-for-lightgbm/comments
Doing a current Kaggle and folks (including me) talking about this.
https://www.kaggle.com/c/champs-scalar-coupling/discussion/98785
I will try to follow the link below – it seems like almost the same as the main page directions but the added images might be enough to get thru and build – for sure path issues and installing all the right extra stuff is my wall to success.
Will also try to follow the 2096 path.
Still would be nice If I did not have to be both a data science guy and a computer guru to get this running on Windows – lots of reasons to not do machine learning on windows – it’s a shame to have this on the list of reasons to not use windows.
Jim
Sent from Mail for Windows 10
From: Nikita Titov
Sent: Wednesday, July 17, 2019 1:04 PM
To: microsoft/LightGBM
Cc: PCJimmmy; Mention
Subject: Re: [microsoft/LightGBM] Suggestion: Also create a lightgbm-gpurelease (#2263)
For #1, I think it's impossible to build gpu wheels due to dependencies (Boost and OpenCL compatibility issues over different machines), refer to:
dotnet/machinelearning#492 (comment),
#544 (comment).
For #2, I guess that @PCJimmmy means something like https://github.com/microsoft/LightGBM/blob/master/docs/GPU-Windows.rst, but for Visual Studio.
For now, maybe this discussion may help a little: #2096.
There was a very nice example of how to build GPU version for Linux on Kaggle in Jupyter notebook.
Can you please provide a link? Then we can ask the author to replicate it here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Thanks for links, @PCJimmmy !
It's enough to be a "middle-guy", neither dummy, nor expert 😃 |
For the possibility of creating |
Closed in favor of being in #2302. We decided to keep all feature requests in one place. Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature. |
Hi, I would like to contribute a PR to do this for CUDA. I'm thinking given all the different GPU backends, best to have an additional package on PyPI, say Does this sound reasonable, such that a PR to that effect would be accepted? |
@itamarst Thanks for the interest in this! I think it's better to wait for some info in #2937 as it promises better support for CUDA. Also, can you please clarify in which way are you planning to contribute? CI script for building packages with CUDA, building all future releases with CUDA on your local machine or what? |
I'm doing some open source consulting for a client that uses LightGBM, and they don't want to have to build the package themselves each time (and presumably, neither do other people). So they would like to have wheels on PyPI with GPU support. They use NVidia GPUs. I am not an expert on GPU toolchain, but if the CUDA support is via OpenCL, and OpenCL is defined via ABI, I guess it wouldn't really be a Or is OpenCL not accessed via an ABI, and you need to compile versions per implementation? |
Given goal of "wheels on PyPI", CI script seems like the way to go. |
I like the idea of creating a For NVIDIA GPUs, OpenCL API is provided as part of the CUDA toolkit. So I think what @itamarst suggests is a |
Given that
can we consider this issue as resolved? |
Thanks for making this connection back to this older issue! I agree, I think we should consider this resolved. I don't think we should pursue publishing CUDA wheels until someone makes a strong case for why the conda packages are not sufficient. |
I have used the Linux package recently - I would close it.
…On Sat, Jul 13, 2024 at 1:09 PM James Lamb ***@***.***> wrote:
Thanks for making this connection back to this older issue!
I agree, I think we should consider this resolved. I don't think we should
pursue publishing CUDA wheels until someone makes a strong case for why the
conda packages are not sufficient.
—
Reply to this email directly, view it on GitHub
<#2263 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEMITCHYUVLGAUKFQAKDL6TZMFNMDAVCNFSM6AAAAABK2MZLHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRWHE4TQNZWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi,
what about the idear that you could also create a lightgbm-gpu package? Like tensorflow also does?
Can you do that?
Thanks
Philip
The text was updated successfully, but these errors were encountered: