Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the breakage in docs into Dataset and Booster params #2772

Closed
StrikerRUS opened this issue Feb 19, 2020 · 0 comments · Fixed by #2779
Closed

make the breakage in docs into Dataset and Booster params #2772

StrikerRUS opened this issue Feb 19, 2020 · 0 comments · Fixed by #2779
Assignees
@StrikerRUS
Labels
in progress

Comments

@StrikerRUS
Copy link
Collaborator

Refer to #2594 (comment).

Can we have a subsection under IO params named Dataset (or somehow better) params? Yes, we have no Booster/Dataset abstraction at CLI level, but with this PR distinguishing becomes very important. Without such info, users have to understand where are Dataset params only via fatal errors they get.
Or maybe we should add a Note to each Dataset parameter about that it cannot be changed after dataset construction.

I agree with the subsection for dataset object, it will be much clearer.
@StrikerRUS StrikerRUS self-assigned this Feb 19, 2020
@StrikerRUS StrikerRUS mentioned this issue Feb 19, 2020
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StrikerRUS StrikerRUS

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Added subsections into param list microsoft/LightGBM
2 participants
@guolinke @StrikerRUS