fatal error: ../../../external_libs/fmt/include/fmt/format.h: No such file or directory

[bsergean]

Description

Installed headers (utils/common.h) reference uninstalled third-party header (format.h).
Those inclusions of un-installed third-party code in public headers make it so that we cannot build the library anymore.

#if (!((defined(sun) || defined(__sun)) && (defined(__SVR4) || defined(__svr4__))))
#define FMT_HEADER_ONLY
#include "../../../external_libs/fmt/include/fmt/format.h"
#endif
#include "../../../external_libs/fast_double_parser/include/fast_double_parser.h"

The error message is

/xxx/include/LightGBM/utils/common.h:35:10: fatal error: ../../../external_libs/fmt/include/fmt/format.h: No such file or directory
   35 | #include "../../../external_libs/fmt/include/fmt/format.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Reproducible example

... todo ...

Environment info

LightGBM version or commit hash: master

This seems to be a regression from 792c930 / before that common/util.h did not include external headers.

I think it would be best to not have headers depend on third-party code, and move that code inside .cpp files or implementation code (under some kind of namespace ?), but an alternative could be to install the fmt code.

spdlog also uses fmt library, maybe their approach could be adopted.

[StrikerRUS]

Just a quick check: have you specified --recursive flag during cloning LightGBM repository?

git clone --recursive https://github.com/microsoft/LightGBM

[bsergean]

Yes I did (I actually used git submodule init + git submodule update but that should be equivalent). I can compile the library just fine, but if I install it in some place on my disk, and then try to compile a standalone project using headers from that install folder, the problem appears.

…

On Feb 8, 2021, at 11:37 AM, Nikita Titov ***@***.***> wrote: Just a quick check: have you specified --recursive flag during cloning LightGBM repository? git clone --recursive https://github.com/microsoft/LightGBM — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3925 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UIXQXP6CEJXTQCLSKTS6A4PVANCNFSM4XJSFWBQ>.

[StrikerRUS]

I guess this issue can treated as a sub-issue of #4067.

I'm adding this to the feature requests list in #2302.

[bholekiran]

I am also getting similar error, eventhough this format.h header is present in that path. Please let me know the solution for this.

/u/sinkib/LightGBM/include/LightGBM/utils/common.h(36): catastrophic error: cannot open source file "../../../external_libs/fmt/include/fmt/format.h"
#include "../../../external_libs/fmt/include/fmt/format.h"

[bholekiran]

@StrikerRUS I am also getting similar error, eventhough this format.h header is present in that path. Please let me know the solution for this.

/u/sinkib/LightGBM/include/LightGBM/utils/common.h(36): catastrophic error: cannot open source file "../../../external_libs/fmt/include/fmt/format.h"
#include "../../../external_libs/fmt/include/fmt/format.h"

[Usmaniatech]

I am also facing this issue:

In file included from /home/jupyter/LightGBM/include/LightGBM/config.h:16:0,
from /home/jupyter/LightGBM/include/LightGBM/boosting.h:8,
from /home/jupyter/LightGBM/src/c_api.cpp:7:
/home/jupyter/LightGBM/include/LightGBM/utils/common.h:33:82: fatal error: ../../../external_libs/fast_double_parser/include/fast_double_parser.h: No such file or directory
#include "../../../external_libs/fast_double_parser/include/fast_double_parser.h"
^
compilation terminated.
In file included from /home/jupyter/LightGBM/include/LightGBM/config.h:16:0,
from /home/jupyter/LightGBM/include/LightGBM/boosting.h:8,
from /home/jupyter/LightGBM/src/boosting/boosting.cpp:5:
/home/jupyter/LightGBM/include/LightGBM/utils/common.h:33:82: fatal error: ../../../external_libs/fast_double_parser/include/fast_double_parser.h: No such file or directory
#include "../../../external_libs/fast_double_parser/include/fast_double_parser.h"
^
compilation terminated.
In file included from /home/jupyter/LightGBM/include/LightGBM/config.h:16:0,
from /home/jupyter/LightGBM/include/LightGBM/boosting.h:8,
from /home/jupyter/LightGBM/src/boosting/gbdt.h:8,
from /home/jupyter/LightGBM/src/boosting/gbdt.cpp:5:
/home/jupyter/LightGBM/include/LightGBM/utils/common.h:33:82: fatal error: ../../../external_libs/fast_double_parser/include/fast_double_parser.h: No such file or directory
#include "../../../external_libs/fast_double_parser/include/fast_double_parser.h"
^
compilation terminated.
In file included from /home/jupyter/LightGBM/include/LightGBM/config.h:16:0,
from /home/jupyter/LightGBM/src/boosting/gbdt_model_text.cpp:5:
/home/jupyter/LightGBM/include/LightGBM/utils/common.h:33:82: fatal error: ../../../external_libs/fast_double_parser/include/fast_double_parser.h: No such file or directory
#include "../../../external_libs/fast_double_parser/include/fast_double_parser.h"
^
compilation terminated.
make[2]: *** [CMakeFiles/lightgbm_objs.dir/src/boosting/boosting.cpp.o] Error 1

were u able to resolve this error.

You can reproduce this error by using:

git clone --recursive https://github.com/microsoft/LightGBM
cd LightGBM
mkdir build
cd build
cmake ..
make -j4

[Usmaniatech]

@bholekiran were you able to resolve it ?

[WatsonCao]

In my case, I solved it use git clone --recursive.

Or you may download corresponding missing files from https://github.com/microsoft/LightGBM/tree/master/external_libs.