Add CTR conversion for categorical features (with bundling support) #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shiyu1994 could you resolve the conflict, and provide some benchmark results? |
guolinke
reviewed
Nov 18, 2019
include/LightGBM/bin.h
Outdated
| * \param value | ||
| * \return whether has value in categorical to bin | ||
| */ | ||
| inline bool HasValueInCat(double value) const; |
There was a problem hiding this comment.
it seems this is not used anymore.
guolinke
reviewed
Nov 18, 2019
include/LightGBM/bin.h
Outdated
| @@ -148,7 +155,7 @@ class BinMapper { | |||
| * \param zero_as_missing True to use zero as missing value | |||
| */ | |||
| void FindBin(double* values, int num_values, size_t total_sample_cnt, int max_bin, int min_data_in_bin, int min_split_data, BinType bin_type, | |||
| bool use_missing, bool zero_as_missing); | |||
| bool use_missing, bool zero_as_missing, bool use_ctr); | |||
|
@shiyu1994 could you rewrite this when have time? |
Ok. I will rewrite it for the latest version of master branch. |
Merged
shiyu1994
force-pushed
the
ctr-for-sparse-features
branch
from
cb6e9f4 to
f5f27ca
Compare
|
Replaced by Pull Request #3234 |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version keeps the original categorical split decisions in trees. We will change to pure numerical decisions in trees soon by recording the mappings from categorical values to CTR values in model. The modification so far only handles the ordinary train and prediction process of LightGBM, other functions like ForceSplits requires further check.