Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] [docs] Added documentation on lgb.dl() and data.table version (fixes #2715) #2846

Merged
merged 4 commits into from
Mar 4, 2020

Conversation

jameslamb
Copy link
Collaborator

Per conversationi n #2715 , this PR adds documentation on the need to upgrade data.table if you are using lgb.dl() to install the R package.

@jameslamb jameslamb requested a review from StrikerRUS February 29, 2020 17:13
@jameslamb jameslamb requested a review from Laurae2 as a code owner February 29, 2020 17:13
@StrikerRUS
Copy link
Collaborator

Seems that I was wrong when suggested to write that warning in R README. I think R section in FAQ is a better place for it. WDYT?

@jameslamb
Copy link
Collaborator Author

Seems that I was wrong when suggested to write that warning in R README. I think R section in FAQ is a better place for it. WDYT?

yep I agree. I forget sometimes that we have that. I'll move this there, and I'll add a note in the README pointing to the FAQ (since we don't currently have that).

@guolinke guolinke added the doc label Mar 1, 2020
@jameslamb jameslamb force-pushed the docs/datatable-version branch from 51fbc2d to 6f6a937 Compare March 4, 2020 05:54
@jameslamb
Copy link
Collaborator Author

Moved everything over to the FAQs page

docs/FAQ.rst Outdated

Avoid printing the ``lgb.Dataset`` after using ``setinfo``.
This is a known bug: `Microsoft/LightGBM#539 <https://github.com/microsoft/LightGBM/issues/539>`__.

3. `error in data.table::data.table()...argument 2 is NULL`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underscore to fix formatting.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! I knew I'd miss one

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

ok looks better now

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@StrikerRUS StrikerRUS merged commit c319474 into microsoft:master Mar 4, 2020
@jameslamb jameslamb deleted the docs/datatable-version branch March 25, 2020 20:01
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants