[ci] fix flaky test #3056
Merged
[ci] fix flaky test #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
approved these changes
May 7, 2020
Merged
|
Thanks! Yeah, our Python wrapper doesn't require any special features from latest versions and thanks to Python internal compatibility our old code works fine with the latest version. Proportion breakdown says that we can safely drop Python 2 support. But in absolute values it is still several thousands of downloads per day. And those thousands are our users. I think we can try to support it for some months or before next minor release as it doesn't cost us anything. |
Merged
ChipKerchner
pushed a commit
to ChipKerchner/LightGBM
that referenced
this pull request
Jun 10, 2020
ChipKerchner
pushed a commit
to ChipKerchner/LightGBM
that referenced
this pull request
Jun 11, 2020
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Linux MPI builds at Azure Pipelines have started to fail (refer for example to #3055). Seems that dropping outdated Python 2.7 version from that build fixes the issue.
On Linux we have tests with Python 2.7 here, so this version is still covered by our CIs.
LightGBM/.travis.yml
Line 18 in 18c706d
Refer to #1964 (comment).