Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed machine list parsing: s/find_first_of/find #3083

Closed
wants to merge 13 commits into from
Closed

Fixed machine list parsing: s/find_first_of/find #3083

wants to merge 13 commits into from

Conversation

odimka
Copy link
Contributor

@odimka odimka commented May 14, 2020

find_first_of matches any of the characters from "rank=", but we really want to match the whole string.

@odimka odimka mentioned this pull request May 14, 2020
Closed
@jameslamb jameslamb added the fix label May 16, 2020
@jameslamb
Copy link
Collaborator

@odimka thank you for the contribution! The C++ reviewers will review it soon.

We recently merged some fixes to LightGBM's CI (#3092). Sorry for the inconvenience, but could you please merge the most recent master into this branch? It will fix issues you might encounter.

jameslamb and others added 12 commits May 17, 2020 22:02
@jameslamb @odimka
[docs] update link to GitHub anchor conventions (microsoft#3085)
d944f9d
@jameslamb @odimka
[R-package] speed up installation with Visual Studio (microsoft#2965)
217a212 
* fix conflicts

* Update R-package/src/install.libs.R

* empty commit
@jameslamb @StrikerRUS @odimka
[R-package] [docs] remove devtools dependency for docs builds (fixes m…
5e64621 
…icrosoft#3036) (microsoft#3072)

* [R-package] [docs] remove devtools dependency for docs builds

* linting

* updating docs conda env

* empty roxygenize()

* env for R libraries

* get logs

* remove comment

* added pkgdown URLs

* more paths

* fix incorrect YAML keys

* update DESCRIPTION URL link

* more URL changes

* revert DESCRIPTION changes

* remove ca-certificates

* empty commit

* Update docs/conf.py

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* empty commit

* remove outdated line in build_r.R

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
@guolinke @odimka
fix goss with constant hessian (microsoft#3077)
1db1878
@jameslamb @odimka
[R-package] [docs] Removed outdated language about the R package (mic…
4f1c07f 
…rosoft#3070)
@jameslamb @odimka
[R-package] fix warnings in tests (microsoft#3069)
b0502ab
@jameslamb @StrikerRUS @odimka
[R-package] [ci] Fix CI timeouts for Mac builds on Travis (fixes micr…
d3d99c0 
…osoft#3091) (microsoft#3092)

* [R-package] use processx to speed up builds

* different fix

* echoing more frequently

* fix it

* more stdout

* use print() instead of message()

* shell tricks

* fix message

* travis

* Update .ci/test_r_package.sh

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
@jameslamb @odimka
[R-package] [docs] fix warnings in pkgdown site building (microsoft#3086
84ddc8e 
)

* [R-package] [docs] fix warnings in pkgdown sitte  building

* trying to get better Travis logs

* trying to get better Travis logs

* undo testing fix

* undo testing fix

* empty commit
@jameslamb @odimka
[ci] avoid duplicatte AppVeyor builds (microsoft#3096)
70839df
@StrikerRUS @odimka
[ci] bump XCode version at Travis (microsoft#3097)
036b627 
* bump XCode version at Travis

* try new AppleClang

* get back to gcc
@guolinke @odimka
fix refactoring bug in voting parallel (microsoft#3089)
600b69f
@jameslamb @odimka
[R-package] [docs] replace build_r_site.R with pkgdown::build_site() (m…
14f98f4 
…icrosoft#3098)

* [R-package] [docs] replace build_r_site.R with pkgdown::build_site()

* fix paths

* fix continuation

* new_process arg
@msftclas
Copy link

msftclas commented May 17, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@guolinke
Copy link
Collaborator

@odimka can you disable these duplicated changes in your PR?

@jameslamb
Copy link
Collaborator

@odimka can you disable these duplicated changes in your PR?

I'm not sure why all these commits from master look like changes, maybe something strange in your git environment. Since this was a one-line change, it might be easiest to close the pull request, pull the latest version of master, branch of that, and create a new pull request.

@odimka odimka closed this May 21, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@btrotta btrotta Awaiting requested review from btrotta

@chivee chivee Awaiting requested review from chivee

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

@huanzhang12 huanzhang12 Awaiting requested review from huanzhang12

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner

@Laurae2 Laurae2 Awaiting requested review from Laurae2

@StrikerRUS StrikerRUS Awaiting requested review from StrikerRUS StrikerRUS is a code owner

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@odimka @jameslamb @msftclas @guolinke @StrikerRUS