Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] DESCRIPTION changes to address CRAN feedback #3298

Merged
merged 13 commits into from
Aug 13, 2020
1 change: 1 addition & 0 deletions R-package/.Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
\.gitkeep$
^docs$
^pkgdown$
^cran-comments\.md$
jameslamb marked this conversation as resolved.
Show resolved Hide resolved

# Objects created by compilation
^.*\.o
Expand Down
7 changes: 3 additions & 4 deletions R-package/DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,20 @@ Authors@R: c(
person("Yachen", "Yan", role = c("ctb")),
person("James", "Lamb", email="jaylamb20@gmail.com", role = c("ctb"))
)
Description: Tree based algorithms can be improved by introducing boosting frameworks. LightGBM is one such framework, and this package offers an R interface to work with it.
Description: Tree based algorithms can be improved by introducing boosting frameworks. 'LightGBM' is one such framework, and this package offers an R interface to work with it.
It is designed to be distributed and efficient with the following advantages:
1. Faster training speed and higher efficiency.
2. Lower memory usage.
3. Better accuracy.
4. Parallel learning supported.
5. Capable of handling large-scale data.
In recognition of these advantages, LightGBM has been widely-used in many winning solutions of machine learning competitions.
Comparison experiments on public datasets suggest that LightGBM can outperform existing boosting frameworks on both efficiency and accuracy, with significantly lower memory consumption. In addition, parallel experiments suggest that in certain circumstances, LightGBM can achieve a linear speed-up in training time by using multiple machines.
In recognition of these advantages, 'LightGBM' has been widely-used in many winning solutions of machine learning competitions.
Comparison experiments on public datasets suggest that 'LightGBM' can outperform existing boosting frameworks on both efficiency and accuracy, with significantly lower memory consumption. In addition, parallel experiments suggest that in certain circumstances, 'LightGBM' can achieve a linear speed-up in training time by using multiple machines.
Encoding: UTF-8
License: MIT + file LICENSE
URL: https://github.com/Microsoft/LightGBM
BugReports: https://github.com/Microsoft/LightGBM/issues
NeedsCompilation: yes
Biarch: false
Suggests:
processx,
testthat
Expand Down
25 changes: 25 additions & 0 deletions R-package/cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# CRAN Submission History

## v3.0.0-1 - Submission 1 - (August 9, 2020)

### CRAN Response

* Debian: 1 NOTE

```text
Possibly mis-spelled words in DESCRIPTION:
LightGBM (12:88, 19:41, 20:60, 20:264)
```

* Windows: 1 ERROR, 1 NOTE

```text
Possibly mis-spelled words in DESCRIPTION:
LightGBM (12:88, 19:41, 20:60, 20:264)

** checking whether the package can be loaded ... ERROR
Loading this package had a fatal error status code 1
Loading log:
Error: package 'lightgbm' is not installed for 'arch = i386'
Execution halted
```
1 change: 1 addition & 0 deletions build-cran-package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ cd ${TEMP_R_DIR}
rm -r src/cmake/
rm -r inst/
rm -r pkgdown/
rm cran-comments.md
rm AUTOCONF_UBUNTU_VERSION
rm recreate-configure.sh

Expand Down