Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trees with linear models at leaves #3299
Trees with linear models at leaves #3299
Changes from all commits
3370bc5
08cb3d1
22040c7
1001383
aa77951
8261f7b
3e43722
0b00394
8f9d69e
566895b
e507f72
3a37ba7
414c028
2fdc4ab
a56fb45
90477db
64da46a
30fc91f
f690536
c1ee624
24930f0
f41c5e7
f6cdc7d
874c1c8
7d9bdad
7d15fa5
7460d53
4fc8121
48e6d5b
bc643c9
a6fa69e
f42f280
0e7ac0f
dfd08da
cda0940
4aa9cc1
d236cb6
692d4b5
3629450
8893e60
35e3ac3
1d34306
26876ad
09e2f34
90c1958
ef0e3dc
7d5f529
7065e7b
b06f825
f8b6ecd
b6f45aa
694b67e
c1e680e
158b984
9fd4129
eb4241c
0ca31dd
d284083
6dc7c09
5f168a6
882b397
9259f67
d32d72f
75f6177
a6d0047
fe487a1
f250c0c
7dd7ac8
94c6912
a02dfc3
919cc35
9ebf454
1f51158
75846fc
5a0dd32
cf40fdb
c92933c
95cd2ff
9648da8
03be117
a097bc1
dbab78b
c11786c
a8ea87a
b8c0cdd
eab9022
a48f4be
d8d2717
d02d84d
34b481d
6ec8097
a8f208d
cb79a9d
1e67f59
360b707
a9c0f96
625db0b
9c75cda
d950f21
dd8fa52
c9cd0a2
8ef65db
8c5d08e
5499875
b50b59c
ea42ec9
d483ed4
f5db131
e740d9b
b4e5da8
5641fc7
68a747c
08d7816
4475197
9c5169b
2e00ef0
70188bd
3513bba
18ccb7f
d00ee09
4410c9c
3b2f4f9
9c9d515
a9201e9
84603fe
0ef2728
548a28d
4dd716c
55a6c8f
047fe3e
0c65173
da3a52a
f31f75e
0a70d6f
71c87a6
d9d1dc2
5062f1a
73e4a25
fb92d10
961ee82
59af8d5
2d1556d
4af6065
576404c
fcbedb3
5398642
5474c89
6120244
8160b2e
7ea85ce
4e6f172
089686b
c07c3a8
ed1e870
171bafc
9eb082f
5775593
c8a4def
24c9dbe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is blocking this from being implemented in R?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry, I see this in the PR description (missed it the first time):
Could you please open an issue with tag
r-package
describing the changes you think are needed in R to support this feature? Then we can implement it later without blocking this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #3319
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain why this interface is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used in the
refit
method of the python interface. When we construct the new dataset for refitting, we need to know if the model is linear, so that we can save the full feature data not just the binned data.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the linear tree will increase the memory usage. I think we should note this in doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use row-first raw data? I guess linear model is faster with row-first data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment: #3299 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, sorry for missing it.