-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] remove unnecessary comments #3356
Conversation
@jameslamb I believe it is not "loss" but "metric" or "evaluation function". Line 121 in d4325c5
Line 595 in d4325c5
Same as above for LightGBM/R-package/R/lgb.train.R Line 98 in d4325c5
Maybe
? LightGBM/R-package/tests/testthat/test_basic.R Lines 15 to 16 in d4325c5
|
@StrikerRUS sure, I agree with all those! Just pushed them: 727fe46 |
@jameslamb Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I agree that those removed comments don't add any value. But I guess that actual approval should come from anyone who is reading/writing R code.
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This PR proposes removing some comments in the R package that I think are unnecessary.
There are a lot of things like this in the R code:
Comments like this don't add any understanding of the code, but they do make it slightly harder to read and possibly lead to false positives when using
git grep
or similar tools to search through the codebase for things.