fix invalid read detected by valgrind #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gha run r-valgrind |
guolinke
commented
Nov 4, 2020
| @@ -22,8 +22,13 @@ namespace LightGBM { | |||
| class LeafSplits { | |||
| public: | |||
| LeafSplits(data_size_t num_data, const Config* config) | |||
| :config_(config), num_data_in_leaf_(num_data), num_data_(num_data), | |||
| : deterministic_(false), | |||
There was a problem hiding this comment.
/gha run r-valgrind
There was a problem hiding this comment.
looks like your changes fixed it!
https://github.com/microsoft/LightGBM/runs/1350825291?check_suite_focus=true
The only issues left there are the ones we already knew about as of #3443 , which we think are false positives.
|
Looks ok to me, but I don't think I'm qualified to give this a ✔️ |
Merged
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #3525