[R-package] fix incorrect passing builds in valgrind checks (fixes #3704) #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Jan 1, 2021
| @@ -14,6 +14,7 @@ RDvalgrind \ | |||
|
|
|||
| cat ${ALL_LOGS_FILE} | |||
|
|
|||
| echo "writing valgrind output to ${VALGRIND_LOGS_FILE}" | |||
There was a problem hiding this comment.
/gha run r-valgrind
There was a problem hiding this comment.
There was a problem hiding this comment.
/gha run r-valgrind
There was a problem hiding this comment.
There was a problem hiding this comment.
ok I think the fix in this PR fixed it! Now this output at the end of the logs shows the correct numbers, so I can tell the stderr redirection is working
writing valgrind output to valgrind-logs.log
valgrind found 0 bytes definitely lost
valgrind found 0 bytes indirectly lost
valgrind found 336 bytes possibly lost
jameslamb
changed the title
jameslamb
commented
Jan 2, 2021
| @@ -10,10 +10,11 @@ RDvalgrind \ | |||
| --vanilla \ | |||
| -d "valgrind --tool=memcheck --leak-check=full --track-origins=yes" \ | |||
| -f testthat.R \ | |||
| 2>&1 > ${ALL_LOGS_FILE} || exit -1 | |||
| > ${ALL_LOGS_FILE} 2>&1 || exit -1 | |||
There was a problem hiding this comment.
this was a silly mistake, sorry 😂
StrikerRUS
approved these changes
Jan 2, 2021
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/microsoft/LightGBM/runs/1632971712?check_suite_focus=true, the valgrind checks on the R package failed but the CI job looked successful.
I think this was because of an incorrect use of shell output redirection in
.ci/test_r_package_valgrind.sh.This PR tries to fix it (#3704).