Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] [dask] Add DaskLGBMRanker #3708
[python-package] [dask] Add DaskLGBMRanker #3708
Changes from 13 commits
b39a161
19dbce6
42149a0
607c857
a33a4de
78358e2
d6e5209
1d6054b
2321692
bb70d11
d472c82
cad5403
d9efb5b
d1d4abf
02aabda
56bb2c9
fc985bf
8c33f56
872c578
53988ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameslamb What about
init_score
? Is it supported or we should add feature request for it?LightGBM/python-package/lightgbm/sklearn.py
Lines 396 to 397 in 1c60cfa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have a feature request. I'll write it up and add a link here.
@ffineis, could you add
init_score=None
here betweensample_weight
andgroup
, so the order matches the sklearn interface forLGBMRanker
? (LightGBM/python-package/lightgbm/sklearn.py
Line 962 in 1c60cfa
fit()
, they won't accidentally have theirinit_score
interpreted asgroup
.And can you just then add a check like this?
@StrikerRUS speaking of positional arguments, I'll open another issue where we can discuss how to handle the
client
argument. But let's leave that out of this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameslamb
Yes, sure! Agree with all your intents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
init_score: #3807
client placement: #3808
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, no prob