Initialize any_nan_ property of LinearTreeLearner #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
approved these changes
Jan 11, 2021
StrikerRUS
reviewed
Jan 11, 2021
| @@ -34,6 +34,7 @@ void LinearTreeLearner::InitLinear(const Dataset* train_data, const int max_leav | |||
| } | |||
| } | |||
| } | |||
| any_nan_ = false; | |||
There was a problem hiding this comment.
✔️
==1916==
==1916== HEAP SUMMARY:
==1916== in use at exit: 308,761,984 bytes in 55,584 blocks
==1916== total heap usage: 2,772,225 allocs, 2,716,641 frees, 6,118,912,031 bytes allocated
==1916==
==1916== 336 bytes in 1 blocks are possibly lost in loss record 152 of 2,682
==1916== at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==1916== by 0x40149CA: allocate_dtv (dl-tls.c:286)
==1916== by 0x40149CA: _dl_allocate_tls (dl-tls.c:532)
==1916== by 0x5706322: allocate_stack (allocatestack.c:622)
==1916== by 0x5706322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==1916== by 0x56D4DDA: ??? (in /usr/lib/x86_64-linux-gnu/libgomp.so.1.0.0)
==1916== by 0x56CC8E0: GOMP_parallel (in /usr/lib/x86_64-linux-gnu/libgomp.so.1.0.0)
==1916== by 0x154C1F21: LGBM_DatasetCreateFromCSC (c_api.cpp:1305)
==1916== by 0x154F10B0: LGBM_DatasetCreateFromCSC_R (lightgbm_R.cpp:91)
==1916== by 0x4942146: R_doDotCall (dotcode.c:634)
==1916== by 0x494CFDD: do_dotcall (dotcode.c:1281)
==1916== by 0x49A06DF: bcEval (eval.c:7072)
==1916== by 0x498C2C0: Rf_eval (eval.c:727)
==1916== by 0x498F02F: R_execClosure (eval.c:1897)
==1916==
==1916== LEAK SUMMARY:
==1916== definitely lost: 0 bytes in 0 blocks
==1916== indirectly lost: 0 bytes in 0 blocks
==1916== possibly lost: 336 bytes in 1 blocks
==1916== still reachable: 308,761,648 bytes in 55,583 blocks
==1916== of which reachable via heuristic:
==1916== newarray : 4,264 bytes in 1 blocks
==1916== suppressed: 0 bytes in 0 blocks
==1916== Reachable blocks (those to which a pointer was found) are not shown.
==1916== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==1916==
==1916== For lists of detected and suppressed errors, rerun with: -s
==1916== ERROR SUMMARY: 3 errors from 2 contexts (suppressed: 0 from 0)
writing valgrind output to valgrind-logs.log
valgrind found 0 bytes definitely lost
valgrind found 0 bytes indirectly lost
valgrind found 336 bytes possibly lost
https://github.com/microsoft/LightGBM/runs/1680889485?check_suite_focus=true
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will fix one of the valgrind issues found in #3699