Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] improve experience with optional GitHub workflows #3740
[ci] improve experience with optional GitHub workflows #3740
Changes from 18 commits
04111bd
c8c3e47
371922c
49b1a87
581711c
1cb0606
d518ed0
84c28aa
57358c8
353d669
f633d7e
0f6225c
30c2f42
cccefa7
0592a12
7bae9fc
3203b95
67c57b6
84a6394
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this necessary? I have a lot more experience with
requests
thanurllib
, so I haven't seen this patternThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for Python 2/3 compatibility. For the same reason I'm not using
with ...
statement but manually close connection. I know we dropped Python 2 support some time ago. But default installed Python version inubuntu-latest
container we run our actions in is 2. I really don't want to install conda/new Python version/additional packages because I want to keepOptional checks
workflow where this script is used as lightweight as possible with the aim of the fastest execution time. So this Python-agnostic and dependency-free solution will work fine on any default Python version that can be installed in container.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I see, thanks. Fine with me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we should add optional workflows which failures should block PR merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I know that direct link for artifact downloading will be more useful. But unfortunately, it is impossible:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha it's ok, we don't use this job that often and it's only one or two more clicks to get to the artifact