-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] expand documentation on 'group' for ranking task #3772
Conversation
Very nice addition! LightGBM/include/LightGBM/config.h Line 674 in 68a40c7
https://lightgbm.readthedocs.io/en/latest/Parameters.html#query-data and unify that description at the bottom of the file with the proposed new one? |
thanks for pointing me to that! I tried an update in 6a42dff, let me know what you think. I built the docs locally like this python helpers/parameter_generator.py
cd docs
make clean html And confirmed that the link to the "Query Data" section worked as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameslamb Yeah, thanks for updating general params doc! Please check my comments.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameslamb Thanks! I believe it's nice addition for beginners.
Feel free to merge after fixing typos below and regenerating Rd
s.
Some R documentation files have changed. Please re-generate them and commit those changes.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Thanks for catching my typos, sorry 😬 I just regenerated the R docs (ec63db8). Will merge this if / when Ci passes. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Based on the discussion in #3708 (comment), this PR proposes adding more details to the explanation of
group
in the Python and R packages.I think that the current description doesn't give enough details for someone unfamiliar with LightGBM to get started. I know that I personally really struggled to understand what "group" should look like the first time I did learning-to-rank with LightGBM.