-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] added f-string to python-package/lightgbm/callback.py #4142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Please see the linter failures at https://github.com/microsoft/LightGBM/pull/4142/checks?check_run_id=2229486239.
I think you will find the development cycle is faster if you run the linters locally while you test fixes. Please see
Lines 60 to 63 in 841943f
pycodestyle --ignore=E501,W503 --exclude=./.nuget,./external_libs . || exit -1 | |
pydocstyle --convention=numpy --add-ignore=D105 --match-dir="^(?!^external_libs|test|example).*" --match="(?!^test_|setup).*\.py" . || exit -1 | |
isort . --check-only || exit -1 | |
mypy --ignore-missing-imports python-package/ || true |
@
me if you need any help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really like to help you get this pull request and the others you've opened as part of #4136 merged this week.
Please update this pull request to the latest master
, and please see the suggestion I just left.
If you don't have time right now to finish this and the other pull requests you've opened for #4136, let me know if you'd prefer that I push directly to your branches. I'd be happy to do that to help with the linting errors (and your name would still be on the commits that are merged).
Thanks again for the time and energy you've put into contributing to LightGBM
!
I merged in the latest changes from the I also patched a few small things. @StrikerRUS I think this is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, but since I added a few changes I don't think my approval should count towards a merge.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
No description provided.