Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] unpin CMake version for CUDA + Clang toolchain #4183

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

StrikerRUS
Copy link
Collaborator

This reverts commit ab474dc.

Refer to #4104.
Closed #4106.

@jameslamb
Copy link
Collaborator

This and other PRs are failing due to a Dockerhub outage

https://status.docker.com/pages/history/533c6539221ae15e3f000031

As of a few hours ago:

[Identified] The Docker Hub Registry is returning 503 responses. The cause has been identified and a fix is in progress.

So I think it should be back up again soon, if it isn't already.

https://github.com/microsoft/LightGBM/pull/4183/checks?check_run_id=2355483437

 /usr/bin/docker pull rhub/rocker-gcc-san
  Using default tag: latest
  Error response from daemon: received unexpected HTTP status: 503 Service Unavailable
  Warning: Docker pull failed with exit code 1, back off 9.918 seconds before retry.
  /usr/bin/docker pull rhub/rocker-gcc-san
  Using default tag: latest
  Error response from daemon: received unexpected HTTP status: 503 Service Unavailable
  Warning: Docker pull failed with exit code 1, back off 2.05 seconds before retry.
  /usr/bin/docker pull rhub/rocker-gcc-san
  Using default tag: latest
  Error response from daemon: received unexpected HTTP status: 503 Service Unavailable
  Error: Docker pull failed with exit code 1

@StrikerRUS StrikerRUS closed this Apr 15, 2021
@StrikerRUS StrikerRUS reopened this Apr 15, 2021
@jameslamb
Copy link
Collaborator

Where did you see that the changes I mentioned in #4106 made it into cmake 3.20.1? I don't see them mentioned in the release notes for CMake: https://cmake.org/cmake/help/latest/release/3.20.html#id2

I believe you that they are, just want to learn if there are other places i should be looking to keep up with CMake.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve if this passes!

@StrikerRUS
Copy link
Collaborator Author

Where did you see that the changes I mentioned in #4106 made it into cmake 3.20.1?

Indeed, Release notes of CMake include only new features and major bug fixes. Seems they treated our issue as not a major one.

I decided to check new version of CMake according to the following Milestone info:

image

@StrikerRUS StrikerRUS merged commit 3fd9b27 into master Apr 16, 2021
@StrikerRUS StrikerRUS deleted the cuda_cmake branch April 16, 2021 10:55
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compatibility with CUDA - Clang - CMake 3.20.0 toolchain
2 participants