-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] change default nrounds to 100 to match LightGBM core library default #4197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for your interest in LightGBM and attention to detail! Please see my comment below about nfold
.
Changed. Co-authored-by: James Lamb <jaylamb20@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
The failing CI job is not related to your changes. I've manually restarted the build, and will merge this when it passes.
Before I merge, I want to check. @StrikerRUS are you ok with this change? |
I'm totally fine with this fix! I remember I spent quite large amount of time syncing Python, native and docs param values several years ago. I'm glad that someone has started working of R-package now! |
Ok thanks! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Fixes #4196
The R interface has some default values for arguments related to training and evaluation which differ from Python, namely:
This PR changes the default values in R to match those of Python.