Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace division of exponential in Gamma loss #4289

Merged
merged 2 commits into from
May 18, 2021

Conversation

lorentzenchr
Copy link
Contributor

This PR replaces / exp(x) by * exp(-x) in the Gamma deviance objective.

It was a finding in #4283.

@jameslamb
Copy link
Collaborator

I added the label efficiency based on #4283 (comment), but @shiyu1994 feel free to change it if you think it would be better categorized as maintenance.

@jameslamb
Copy link
Collaborator

Sorry for the inconvenience, but we recently merged a fix for some CI issues (#4288 ). Whenever you have time, could you please update this branch to the latest master? That should fix the failing builds.

@shiyu1994
Copy link
Collaborator

@lorentzenchr @jameslamb The changes LGTM.

@StrikerRUS StrikerRUS changed the title ENH replace division of exponential Replace division of exponential in Gamma loss May 18, 2021
@StrikerRUS StrikerRUS merged commit 32fec82 into microsoft:master May 18, 2021
@lorentzenchr lorentzenchr deleted the gamma_division_exp branch May 18, 2021 13:49
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants