[fix] fix GatherInfoForThresholdNumerical boundary (fix #4286) #4322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #4286. In
GatherInfoForThresholdNumerical
, since it is calculating the right sum statistics, it should break whenstatic_cast<uint32_t>(t + offset) <= threshold
instead ofstatic_cast<uint32_t>(t + offset) < threshold
. Because data with bin value<= threshold
are split into the left child node.