Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] use f-strings for concatenation in examples/python-guide/logistic_regression.py #4355

Closed
wants to merge 2 commits into from

Conversation

sagnik1511
Copy link
Contributor

@sagnik1511 sagnik1511 commented Jun 8, 2021

Contributes to #4136.

Updated .\examples\python-guide\logistic_regression.py file

@jameslamb jameslamb changed the title Migrated f-string codebase [python-package] use f-strings for concatenation in examples/python-guide/logistic_regression.py Jun 8, 2021
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

Please also change the following places:


Some other general notes as well, which maintainers will appreciate in the future

  • When you open a pull request, please reference any previous discussions in the description so that maintainers have enough context to understand the proposed changes. I've added "Contributes to Migrate to f-strings for the Python code #4136" to the PR description here.
  • In the future, please use an informative title for your pull requests. This helps people to find it in the future from search, and makes the changelog for releases (e.g. https://github.com/microsoft/LightGBM/releases/tag/v3.2.1) easier to understand. "Migrated f-string codebase" is too broad. I've updated the title to be a bit more specific.
  • In pull requests, it isn't necessary to explicitly write out what code changed. The PR description should just give a description of what you're proposing and why.

@sagnik1511 sagnik1511 closed this Jun 8, 2021
@sagnik1511
Copy link
Contributor Author

Thanks so much for this!

Please also change the following places:

Some other general notes as well, which maintainers will appreciate in the future

  • When you open a pull request, please reference any previous discussions in the description so that maintainers have enough context to understand the proposed changes. I've added "Contributes to Migrate to f-strings for the Python code #4136" to the PR description here.
  • In the future, please use an informative title for your pull requests. This helps people to find it in the future from search, and makes the changelog for releases (e.g. https://github.com/microsoft/LightGBM/releases/tag/v3.2.1) easier to understand. "Migrated f-string codebase" is too broad. I've updated the title to be a bit more specific.
  • In pull requests, it isn't necessary to explicitly write out what code changed. The PR description should just give a description of what you're proposing and why.

Thank you sir for your kind words. I've pulled a new request here. DO visit that :)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants