fix param aliases #4387
Merged
fix param aliases #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
requested review from
btrotta,
chivee,
guolinke,
henry0312,
jameslamb,
Laurae2,
shiyu1994 and
wxchan
as code owners
StrikerRUS
force-pushed
the
dataset_params
branch
from
d62bac0 to
135d38c
Compare
StrikerRUS
force-pushed
the
dataset_params
branch
from
135d38c to
87c8ce4
Compare
jameslamb
approved these changes
Jun 19, 2021
|
@btrotta What do you think about moving |
chivee
approved these changes
Jun 24, 2021
@StrikerRUS this seems fine to me, since choosing |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precise_float_parserto Dataset params at language wrappers level and raise error in case of new value in config for constructed Datasetlinear_treeparam to Dataset section (open to discussion about another way how indicate the fact thatlinear_treeconfig value is used at Dataset creation step)