[python] migrate to pathlib in python tests #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
commented
Jul 4, 2021
| @@ -1090,7 +1090,7 @@ def test_model_and_local_version_are_picklable_whether_or_not_client_set_explici | |||
| assert "client" not in local_model.get_params() | |||
| assert getattr(local_model, "client", None) is None | |||
|
|
|||
| tmp_file = str(tmp_path / "model-1.pkl") | |||
| tmp_file = tmp_path / "model-1.pkl" | |||
There was a problem hiding this comment.
joblib has been supporting pathlib.Path since 2016.
https://github.com/joblib/joblib/pull/316/files
StrikerRUS
force-pushed
the
pathlib3
branch
2 times, most recently
from
0961900 to
f4abac5
Compare
StrikerRUS
requested review from
btrotta,
chivee,
guolinke,
henry0312,
jameslamb and
shiyu1994
as code owners
jameslamb
approved these changes
Jul 4, 2021
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4416.