-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] move Solaris and valgrind test steps into scripts #4503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really useful refactoring! Thanks!
Please check my initial comments below.
.ci/test_r_package_solaris.sh
Outdated
libxml2-dev \ | ||
libssl-dev | ||
|
||
log_file="$GITHUB_WORKSPACE/rhub_logs.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to not use CI service dependable env variables in bash scripts (try to search for GITHUB_WORKSPACE
: it is used only in config yml
files).
I guess we can switch to relative paths here just like in test_r_package_valgrind.sh
LightGBM/.ci/test_r_package_valgrind.sh
Lines 5 to 13 in 2f37642
ALL_LOGS_FILE="out.log" | |
VALGRIND_LOGS_FILE="valgrind-logs.log" | |
RDvalgrind \ | |
--no-readline \ | |
--vanilla \ | |
-d "valgrind --tool=memcheck --leak-check=full --track-origins=yes" \ | |
-f testthat.R \ | |
> ${ALL_LOGS_FILE} 2>&1 || exit -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point! fixed in 10deff6
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
…nto ci/develop-optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's check these changes in a next PR.
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
#3946 introduces two new
Suggests
-level dependencies for the R package.To run the Solaris and valgrind tests successfully, those dependencies need to be added to the jobs for those tests (https://github.com/microsoft/LightGBM/blob/master/.github/workflows/r_solaris.yml and https://github.com/microsoft/LightGBM/blob/master/.github/workflows/r_valgrind.yml).
This creates an interesting challenge. Right now changes like that need to be made in the workflow files in
.github/workflows/
, but when those jobs are triggered by comments they source those configs frommaster
(#4397 (comment)).This PR proposes moving more of the logic for those checks into scripts in
.ci/
. That will make it possible to test the following types of changes to the Solaris and valgrind jobs before merging them:install.packages()
install.packages()
(e.g. [ci] parallelize R package installs in CI jobs #4198)apt-get install
'd dependencies for the Solaris checksRdvalgrind CMD INSTALL
in the valgrind checks