Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] upgrade R to 4.1.1 #4560

Merged
merged 2 commits into from
Aug 26, 2021
Merged

[ci] upgrade R to 4.1.1 #4560

merged 2 commits into from
Aug 26, 2021

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Aug 26, 2021

Upgrades R to 4.1.1 in CI.

Linking to #3763

R 4.1.1 was released a few days ago. I don't see anything in https://cran.r-project.org/doc/manuals/r-release/NEWS.html that immediately jumps out as relevant to {lightgbm}, so this is just a routine CI update.

Notes for Reviewers

Marking this as blocking since CI on other PRs is failing due to warnings about this version:

*** arch - i386
Warning: package 'R6' was built under R version 4.1.1
*** arch - x64
Warning: package 'R6' was built under R version 4.1.1
** testing if installed package can be loaded from final location
*** arch - i386
Warning: package 'R6' was built under R version 4.1.1
*** arch - x64
Warning: package 'R6' was built under R version 4.1.1
** testing if installed package keeps a record of temporary installation path
NOTEs, WARNINGs, or ERRORs have been found by R CMD check

for example, from #4559: https://github.com/microsoft/LightGBM/pull/4559/checks?check_run_id=3427595691

@jameslamb
Copy link
Collaborator Author

I see the following new warning on Windows builds.

* checking for detritus in the temp directory ... NOTE

Found the following files/directories:

  'lastMiKTeXException'

Searching on GitHub, I found @StrikerRUS 's fix over in {RGF}: https://github.com/RGF-team/rgf/pull/349/files#r693281911

Pushed that fix here.

@jameslamb jameslamb changed the title WIP: [ci] upgrade R to 4.1.1 [ci] upgrade R to 4.1.1 Aug 26, 2021
@jameslamb jameslamb marked this pull request as ready for review August 26, 2021 19:11
@jameslamb jameslamb requested a review from StrikerRUS as a code owner August 26, 2021 19:11
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I was wondering why I couldn't find any mentions of lastMiKTeXException in internet except MikTeX sources during struggling with it in RGF. I hope someone will report this incompatibility of MikTeX and CRAN checks in appropriate place.

Thank you for this PR!

@StrikerRUS StrikerRUS merged commit 8a07ed2 into master Aug 26, 2021
@jameslamb jameslamb deleted the ci/r-4.1.1 branch August 26, 2021 19:15
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants