Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] fix inaccurate error message in Dataset get_colnames() method #4588

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

jameslamb
Copy link
Collaborator

Noticed while working on #4586.

An error message in Dataset$get_colnames() currently references Dataset$dim(), which is inaccurate and might lead to confusion.

This PR fixes that error message.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keen eye, LGTM!

R-package/R/lgb.Dataset.R Outdated Show resolved Hide resolved
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
@jameslamb jameslamb merged commit dc09d1b into master Sep 2, 2021
@jameslamb jameslamb deleted the r/colnames-log branch September 2, 2021 17:34
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants