remove unused DCGCalculator::CalDCGAtK() #4650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cppcheck
shows the following warning (#4539 (comment))I confirmed that this method is not called anywhere in the library, using
git grep CalDCGAtK
. I think it's safe to remove, since only the code insrc/c_api.cpp
is considered parrt of the public API for LightGBM.I also double-checked and don't see this method referenced in the in-progress CUDA work (#4528, #4630).
Notes for Reviewers
I checked the git blame to see if this method had been added for a specific purpose in the past, but don't see anything like that. It was part of the first commit on the project.
https://github.com/microsoft/LightGBM/blame/e95d5ab849f046b8fdf755441e5767094aeb8de2/src/metric/dcg_calculator.cpp#L56