Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix CI Windows script to use downloaded SWIG, not the pre-installed one #4711

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Oct 23, 2021

Prepend PATH variable (currently appended) with downloaded SWIG directory, to avoid using pre-installed unknown SWIG version.

master branch:

...
-- Found SWIG: C:/ProgramData/chocolatey/bin/swig.exe (found version "4.0.2")
...

https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=11269&view=logs&j=457fb6cd-b9a6-52d5-ab83-9fdcfc761c31&t=302dfe64-6e46-5035-7255-9ce91154684d&l=186

This PR:

...
-- Found SWIG: D:/a/1/s/swig/swigwin-4.0.2/swig.exe (found version "4.0.2")
...

https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=11312&view=logs&j=457fb6cd-b9a6-52d5-ab83-9fdcfc761c31&t=302dfe64-6e46-5035-7255-9ce91154684d&l=186

@StrikerRUS StrikerRUS marked this pull request as ready for review October 23, 2021 17:03
@StrikerRUS StrikerRUS requested a review from jameslamb as a code owner October 23, 2021 17:03
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, chocolatey hits us again haha

thanks for rhe fix!

@StrikerRUS StrikerRUS merged commit 47554c3 into master Oct 23, 2021
@StrikerRUS StrikerRUS deleted the swig_path branch October 23, 2021 19:06
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants