[R-package] remove internal function lgb.check.obj() #5021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5007 (comment). The R package has an internal function,
lgb.check.obj()
, that has been there since the very beginning of the R package (#168).All of the things it does or once did are already handled by other parts of the code base.
objective
and keyword argumentLightGBM/R-package/R/lgb.train.R
Lines 95 to 99 in 820ae7e
LightGBM/R-package/R/lgb.train.R
Lines 109 to 113 in 820ae7e
LightGBM/src/objective/objective_function.cpp
Line 51 in d517ba1
This PR proposes removing
lgb.check.obj()
from the R package, to reduce maintenance burden for the package and remove the risk of bugs caused by that code.Notes for Reviewers
Should be merged prior to #4976.