Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] remove internal function lgb.check.obj() #5021

Merged
merged 5 commits into from
Feb 23, 2022

Conversation

jameslamb
Copy link
Collaborator

Based on #5007 (comment). The R package has an internal function, lgb.check.obj(), that has been there since the very beginning of the R package (#168).

All of the things it does or once did are already handled by other parts of the code base.

  1. resolve parameter aliases for objective and keyword argument
  2. extract custom objective functions written in R
  3. raise an informative error for unrecognized objectives

This PR proposes removing lgb.check.obj() from the R package, to reduce maintenance burden for the package and remove the risk of bugs caused by that code.

Notes for Reviewers

Should be merged prior to #4976.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Nice to see this simplification! 🙂

@jameslamb
Copy link
Collaborator Author

Just updated this branch to get the CI fixes from #5022

@jameslamb jameslamb merged commit a1fbe84 into master Feb 23, 2022
@jameslamb jameslamb deleted the misc/lgb-check-obj branch February 23, 2022 02:47
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants