Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] [R-package] ensure that MSVC jobs fail when tests fail (fixes #5439) #5448

Merged
merged 38 commits into from
Sep 12, 2022
Merged

[ci] [R-package] ensure that MSVC jobs fail when tests fail (fixes #5439) #5448

merged 38 commits into from
Sep 12, 2022

Commits on Aug 29, 2022

  1. comment out other CI

    @jameslamb
    jameslamb committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    90753b3 View commit details
    Browse the repository at this point in the history

  2. test a different way to run unit tests

    @jameslamb
    jameslamb committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    b9eebb3 View commit details
    Browse the repository at this point in the history

  3. revert intentional test failure

    @jameslamb
    jameslamb committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    7ce18e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. merge master

    @jameslamb
    jameslamb committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    6836971 View commit details
    Browse the repository at this point in the history

  2. test different srategies for different versions

    @jameslamb
    jameslamb committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    10d15cc View commit details
    Browse the repository at this point in the history

  3. test what happens under failures

    @jameslamb
    jameslamb committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    4f7c9a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Merge branch 'master' into fix/msvc-tests

    @jameslamb
    jameslamb committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    0b946f8 View commit details
    Browse the repository at this point in the history

  2. trying omitting docs

    @jameslamb
    jameslamb committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    07108e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. test if this is actually related to testthat

    @jameslamb
    jameslamb committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    c4fea40 View commit details
    Browse the repository at this point in the history

  2. maybe the issue is with source()

    @jameslamb
    jameslamb committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    96ef848 View commit details
    Browse the repository at this point in the history

  3. try exiting earlier

    @jameslamb
    jameslamb committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    307d0e4 View commit details
    Browse the repository at this point in the history

  4. revert difference in approach

    @jameslamb
    jameslamb committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2c12676 View commit details
    Browse the repository at this point in the history

  5. try getting more logs

    @jameslamb
    jameslamb committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    46bcd18 View commit details
    Browse the repository at this point in the history

  6. check that jobs succeed when they should

    @jameslamb
    jameslamb committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    9b77a8b View commit details
    Browse the repository at this point in the history

  7. remove extra sink() that was raising a warning

    @jameslamb
    jameslamb committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    d7be35e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into fix/msvc-tests

    @jameslamb
    jameslamb committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    f739694 View commit details
    Browse the repository at this point in the history

  9. stop suppressing warnings

    @jameslamb
    jameslamb committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    28aba19 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. trying more options

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    538e8a4 View commit details
    Browse the repository at this point in the history

  2. get more logs

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    58e1ab1 View commit details
    Browse the repository at this point in the history

  3. actually get settings

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    035eac7 View commit details
    Browse the repository at this point in the history

  4. change ErrorActionPreference

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1f675ce View commit details
    Browse the repository at this point in the history

  5. trying things

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    7c8f2bd View commit details
    Browse the repository at this point in the history

  6. more logs

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    fd809ae View commit details
    Browse the repository at this point in the history

  7. check if it is related to specific tests

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a075579 View commit details
    Browse the repository at this point in the history

  8. start uncommenting tests

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    752afe7 View commit details
    Browse the repository at this point in the history

  9. remove workarounds

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1a397ed View commit details
    Browse the repository at this point in the history

  10. remove more workarounds and comment out a few more tests

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4ffc47d View commit details
    Browse the repository at this point in the history

  11. figure out where tests are failing

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e745b75 View commit details
    Browse the repository at this point in the history

  12. try commenting out the one problematic test

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    649b145 View commit details
    Browse the repository at this point in the history

  13. check if this fails with R 4.1

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6e40de5 View commit details
    Browse the repository at this point in the history

  14. uncomment more workarounds

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    564cf16 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'master' into fix/msvc-tests

    @jameslamb
    jameslamb committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c6a2f20 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. uncomment more CI

    @jameslamb
    jameslamb committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    fa7f645 View commit details
    Browse the repository at this point in the history

  2. remove more debugging stuff

    @jameslamb
    jameslamb committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    18aa126 View commit details
    Browse the repository at this point in the history

  3. introduce an intentional failure

    @jameslamb
    jameslamb committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    aff9acf View commit details
    Browse the repository at this point in the history

  4. revert all remaining debugging stuff

    @jameslamb
    jameslamb committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    0316831 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. add comment on use of Rscript.exe, clarify skip message

    @jameslamb
    jameslamb committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    121e117 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/msvc-tests

    @jameslamb
    jameslamb committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    3491561 View commit details
    Browse the repository at this point in the history