WIP: [ci] [R-package] re-enable clang-18 testing (fixes #6369) #6381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6116
Fixes #6369
CRAN tests every submission with R-devel and
clang-18. Until #6357, LightGBM's CI did as well, to reduce the risk of issues during submissions of the R package to CRAN.As documented in #6369, those
clang-18CI jobs started failing a few weeks ago.The root cause? It seems that the
rhub/debian-clang-develimages are no longer getting updated, and the newclang-18packages can't be installed in the last released version (#6369 (comment)).The maintainers of that image and the others used by R Hub appear to have abandoned https://github.com/r-hub/rhub-linux-builders in favor of https://github.com/r-hub/containers. This PR proposes re-enabling
clang-18tests by using an image from https://github.com/r-hub/containers.Notes for Reviewers
This new test uses Ubuntu, not Debian
According to https://r-hub.github.io/containers/, the image that project uses to mimic
r-devel-linux-x86_64-debian-clangis an Ubuntu image.So it's not Debian... but testing against R-devel + clang-18 on every commit would be better than not testing that combination. And I'm proposing keeping the clang-16 and clang-17 jobs running on
rhub/debian-clang-develfor as long as we can keep them working.