Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Always use latest SWIG version in Windows CI job #6541

Merged
merged 14 commits into from
Aug 2, 2024
Merged

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Jul 14, 2024

Cross-reference: guolinke/lightgbm-ci-docker#34.

Linux: guolinke/lightgbm-ci-docker#34.
Windows: this PR.
macOS: automatically via brew

-- Found SWIG: D:/a/1/s/swig/swigwin-4.2.1/swig.exe (found version "4.2.1")
https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=16635&view=logs&j=457fb6cd-b9a6-52d5-ab83-9fdcfc761c31&t=40a6bcc9-8386-5961-d087-81a8347de505&l=52

@StrikerRUS StrikerRUS changed the title [DO NOT MERGE] Update SWIG version [ci] Update SWIG version in Windows CI job Jul 15, 2024
@StrikerRUS StrikerRUS marked this pull request as ready for review July 15, 2024 00:49
@StrikerRUS
Copy link
Collaborator Author

Sorry for early review requests! I just came to the idea that it's possible to use the latest SWIG version.

@StrikerRUS StrikerRUS marked this pull request as draft July 15, 2024 01:00
@StrikerRUS StrikerRUS changed the title [ci] Update SWIG version in Windows CI job [ci] Always use latest SWIG version in Windows CI job Jul 16, 2024
@@ -24,11 +24,22 @@ if ($env:TASK -eq "cpp-tests") {
if ($env:TASK -eq "swig") {
$env:JAVA_HOME = $env:JAVA_HOME_8_X64 # there is pre-installed Eclipse Temurin 8 somewhere
$ProgressPreference = "SilentlyContinue" # progress bar bug extremely slows down download speed
Invoke-WebRequest -Uri "https://github.com/microsoft/LightGBM/releases/download/v2.0.12/swigwin-4.0.2.zip" -OutFile $env:BUILD_SOURCESDIRECTORY/swig/swigwin.zip -UserAgent "NativeHost"
Invoke-WebRequest -Uri "https://sourceforge.net/projects/swig/files/latest/download" -OutFile $env:BUILD_SOURCESDIRECTORY/swig/swigwin.zip -UserAgent "curl"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With -UserAgent "NativeHost" site redirects to Unix .tar.gz version.

@StrikerRUS StrikerRUS marked this pull request as ready for review July 16, 2024 20:49
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. Thanks for adding the test confirming that the expected version was used.

@jameslamb jameslamb merged commit 29b48f6 into master Aug 2, 2024
45 checks passed
@jameslamb jameslamb deleted the ci/swig branch August 2, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants