-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Always use latest SWIG version in Windows CI job #6541
Conversation
Sorry for early review requests! I just came to the idea that it's possible to use the latest SWIG version. |
.ci/test_windows.ps1
Outdated
@@ -24,11 +24,22 @@ if ($env:TASK -eq "cpp-tests") { | |||
if ($env:TASK -eq "swig") { | |||
$env:JAVA_HOME = $env:JAVA_HOME_8_X64 # there is pre-installed Eclipse Temurin 8 somewhere | |||
$ProgressPreference = "SilentlyContinue" # progress bar bug extremely slows down download speed | |||
Invoke-WebRequest -Uri "https://github.com/microsoft/LightGBM/releases/download/v2.0.12/swigwin-4.0.2.zip" -OutFile $env:BUILD_SOURCESDIRECTORY/swig/swigwin.zip -UserAgent "NativeHost" | |||
Invoke-WebRequest -Uri "https://sourceforge.net/projects/swig/files/latest/download" -OutFile $env:BUILD_SOURCESDIRECTORY/swig/swigwin.zip -UserAgent "curl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With -UserAgent "NativeHost"
site redirects to Unix .tar.gz
version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this. Thanks for adding the test confirming that the expected version was used.
Cross-reference: guolinke/lightgbm-ci-docker#34.
Linux: guolinke/lightgbm-ci-docker#34.
Windows: this PR.
macOS: automatically via
brew