Handle long paths #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfederm
reviewed
Jan 19, 2024
| @@ -25,6 +25,7 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <InternalsVisibleTo Include="Microsoft.MSBuildCache.Common.Tests" /> | |||
| <InternalsVisibleTo Include="Microsoft.MSBuildCache.AzurePipelines" /> | |||
There was a problem hiding this comment.
This should be avoided. Our plugin impls should not be "special" in any way.
Just make whatever you need public instead.
dfederm
reviewed
Jan 19, 2024
| @@ -230,8 +230,8 @@ internal sealed class PipelineCachingCacheClient : CacheClient | |||
| // 3. map all the relative paths to the temp files | |||
| foreach (KeyValuePair<AbsolutePath, ContentHash> output in outputs) | |||
| { | |||
| string relativePath = output.Key.Path.Replace(RepoRoot.Path, "", StringComparison.OrdinalIgnoreCase); | |||
| extras.Add(relativePath.Replace("\\", "/", StringComparison.Ordinal), new FileInfo(tempFilesPerHash[output.Value].Path)); | |||
| RelativePath relativePath = output.Key.MakePathRelativeTo(RepoRoot)!; | |||
There was a problem hiding this comment.
There seem to be a ton of type conversions here.
output.Key starts as a AbsolutePath, then in MakePathRelativeTo gets converted to a string then back to a RelativePath on return, then immediately it's converted back to a string.
Can we just use strings everywhere?
There was a problem hiding this comment.
It looks like the input being an AbsolutePath is what's adding this long path prefix in the first place. So it's being added just to remove it again!
I'll just fix it as part of #35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.