Tolerate dependencies outside the repo when adding to cache #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tolerate dependencies outside the repo when adding to cache.
This supports scenarios like NerdBank.GitVersioning which end up adding a projects inside the package to the graph, which ends up getting ignored.
Before this change, this would result in all cache misses for repos using NerdBank.GitVersioning.
Note that projects outside of the repo which are built in this manner are not considered at all for cache fingerprinting, so any changes in those projects will not cause projects to rebuild, just like any other file read outside the repo (and outside NuGet packages).