Fix stdin encoding for Git... again #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyGerlicher
approved these changes
Oct 23, 2024
|
Yeah, I mentioned AutoFlush in #84 (comment). But if #89 did not fix the bug, why were the PR checks all green; does this need a new test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, I thought wrapping the underlying stream with a writer with another encoder would work (see #84), but it appears that
ProcesssetsAutoFlush, which immediately writes that encoding's preamble (the BOM in this case) to the stream.After a bunch of trial and error, I couldn't figure out a way to start a process using
Processwithout writing a BOM to stdin, so decided to just completely copy/paste theProcessclass and customize it, which really is a terrible workaround. I did remove a bunch of the unused features though to save a few thousand lines of copy/pasted code from .NET Framework, but it's still a pretty huge amount of copy/paste.Oh well, I guess it works.