-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Code and Fixed Some Warning ⚠ #10526
Update Code and Fixed Some Warning ⚠ #10526
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Why do the pipelines make some errors? |
@BillyFrcs , neither Unity 2018 nor Unity 2019 support switch pattern matching. |
Alright understood, Thanks for the correction @timGerken I've already revert it. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Commenter does not have sufficient privileges for PR 10526 in repo microsoft/MixedRealityToolkit-Unity |
Assets/MRTK/SDK/Features/UX/Scripts/Pointers/BaseControllerPointer.cs
Outdated
Show resolved
Hide resolved
Hey @BillyFrcs, I really appreciate you taking the time to address our feedback. We need all of the public fields that were changed to private/protected be reverted back to public, since they are breaking changes to our api. We'd also like you to retarget this branch to prerelease/2.8.0 to get this in if you have the time. |
Okay, I'll try to take it back. |
Assets/MRTK/SDK/Features/UX/Scripts/Pointers/BaseControllerPointer.cs
Outdated
Show resolved
Hide resolved
Assets/MRTK/SDK/Features/UX/Scripts/Pointers/TeleportPointer.cs
Outdated
Show resolved
Hide resolved
Assets/MRTK/SDK/Features/UX/Scripts/Pointers/ShellHandRayPointer.cs
Outdated
Show resolved
Hide resolved
…er.cs Co-authored-by: Kurtis <kurtie@microsoft.com>
@@ -96,7 +97,7 @@ public override void Enable() | |||
private async void EnableIfLoaderBecomesActive() | |||
{ | |||
await new WaitUntil(() => IsActiveLoader.HasValue); | |||
if (IsActiveLoader.Value) | |||
if (IsActiveLoader != null && IsActiveLoader.Value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keveleigh is the != null check necessary here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be, since we do it after we call IsActiveLoader.HasValue
without a null check in the previous line.
Sorry for the delay on accepting this PR. Left some last comments, after which I think this PR should be good to go! |
Alright, no problem! |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Overview
Possible System.InvalidOperationException
warning.public
method toprivate
because it's not being use in the other class andprotected
as well.Possible System.NullReferenceException
warning.Changes
Possible System.NullReferenceException
warning.Possible System.InvalidOperationException
warning