Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TouchPointer NullReferenceException #11036

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Fix TouchPointer NullReferenceException #11036

merged 1 commit into from
Sep 20, 2022

Conversation

manuelpezzera
Copy link
Contributor

Overview

Fixed the NullReferenceException that occurs when using the TouchPointer on mobile devices (MRTK 2.8.2).

Changes

@github-actions github-actions bot added the MRTK2 label Sep 20, 2022
@ghost
Copy link

ghost commented Sep 20, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

RogPodge
RogPodge approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@RogPodge RogPodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that the InputSourceParent could end up being null. This starts digging a bit deep into the implementation of the libraries raising these input sources, but I think we should be good if adding these safeguards stops the propogation of errors.

@RogPodge
Copy link
Contributor

@keveleigh when you get back for visibility

@RogPodge RogPodge merged commit f1f4f42 into microsoft:main Sep 20, 2022
AlihanAt pushed a commit to AlihanAt/ARMaps that referenced this pull request Dec 5, 2022
MRTK Fix
f03ef80 
Bug das Buttons auf Android nicht funktionierten. Sollte somit behoben sein.
Link: microsoft/MixedRealityToolkit-Unity#11036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogPodge RogPodge RogPodge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AR Foundation NullReferenceException
2 participants
@manuelpezzera @RogPodge