Add IMixedRealityDataProviderAccess and update how data providers are retrieved #4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lete spatial awareness GetObserver methods
…lete spatial awareness GetObserver methods
…s/MixedRealityToolkit-Unity into inputProviderAccess
…taProviderAccess.cs
…ProviderAccess_rc2
david-c-kline
changed the title
wiwei
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is an RC 2 targetted version of #4466. The previous PR got updated to newer dev branch code prematurely, hence it being recreated.
Below is the original PR description:
This change introduces IMixedRealityDataProviderAccess, which allows system implementations a standard contract through which they can allow components access to data provider instances.
As an example, the solver handler now accesses the hand joint service using the following pattern
handJointService = (InputSystem as IMixedRealityDataProviderAccess)?.GetDataProvider()
This change also adds IMixedRealityMouseDeviceManager to allow for easy recognition of mouse data providers.
To ensure consistency across services with data providers, the spatial awareness system's GetObserver* methods have been marked as obsolete, with a message to check for implementation of IMixedRealityDataProviderAccess and to call GetDataProvider*.
Note: The existing GetObserver* implementations now call the GetDataProvider* equivalents.
This change is part of the #3545 series and gets non-editor code (with a handful of small exceptions) entirely on to the new, flexible pattern.