Cut duplicate code #261
Merged
Cut duplicate code #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adr1anh
reviewed
Nov 16, 2023
Comment on lines
+982
to
+994
| #[cfg(feature = "asm")] | ||
| test_pp_digest_with::<bn256::Point, grumpkin::Point, _, _>( | ||
| &trivial_circuit1_grumpkin, | ||
| &trivial_circuit2_grumpkin, | ||
| "c4ecd363a6c1473de7e0d24fc1dbb660f563556e2e13fb4614acdff04cab7701", | ||
| ); | ||
| #[cfg(feature = "asm")] | ||
| test_pp_digest_with::<bn256::Point, grumpkin::Point, _, _>( | ||
| &cubic_circuit1_grumpkin, | ||
| &trivial_circuit2_grumpkin, | ||
| "4853a6463b6309f6ae76442934d0a423f51f1e10abaddd0d39bf5644ed589100", | ||
| ); | ||
| #[cfg(not(feature = "asm"))] |
There was a problem hiding this comment.
How come does the assembly implementation generate a different digest?
There was a problem hiding this comment.
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Nov 22, 2023
* Simplify Group trait (microsoft#259) * simplify Group trait * fix clippy * further simplifications * fix Copy * Cut duplicate code (microsoft#261) * cut duplicate code * bound --> bind for clarity * expose asm feature * test: check test_pp_digest with asm feature in CI * expose size of the base field (microsoft#262) * fix: add mention of halo2curves issue explaining the problem --------- Co-authored-by: Srinath Setty <srinath@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some renames for improved clarity
Exposes asm feature of halo2curves