Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oss-download should return non-zero error when download fails #274

Closed
scovetta opened this issue Nov 11, 2021 · 0 comments
Closed

oss-download should return non-zero error when download fails #274

scovetta opened this issue Nov 11, 2021 · 0 comments

Comments

@scovetta
Copy link
Member

Currently, if oss-download doesn't download anything, nothing happens -- it's just the banner. We should instead return an errorlevel (non-zero) for errors. In the future, we could differentiate based on the type of error, but for now, maybe just '1' for any error.
gfs added a commit that referenced this issue Nov 11, 2021
@gfs
Fix #274
0e01b8f
@gfs gfs closed this as completed in dd3d244 Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scovetta