Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DiscUtils to MyGet version #100

Merged
merged 5 commits into from
Jun 3, 2020
Merged

Update DiscUtils to MyGet version #100

merged 5 commits into from
Jun 3, 2020

Conversation

gfs
Copy link
Contributor

@gfs gfs commented Jun 2, 2020

No description provided.

@jacobmsft
Copy link
Member

checkin after fixing the tests of course

@daalcant
Copy link
Contributor

daalcant commented Jun 3, 2020

I can get the restore working with the NuGet.Config file, but the DiscUtils version (0.16.0-alpha0020) being targeted isn't available at the MyGet feed selected (yet). Looks like the DiscUtils CI deployment is failing:
https://ci.appveyor.com/project/LordMike/discutils

This PR is blocked by the above.

@gfs
Copy link
Contributor Author

gfs commented Jun 3, 2020

I swear this works locally. I wonder why it's not in the feed from the server. I'll take another look tomorrow.

@daalcant
Copy link
Contributor

daalcant commented Jun 3, 2020

I swear this works locally. I wonder why it's not in the feed from the server. I'll take another look tomorrow.

I may be wrong about the package not being available, but I can't work out the errors I'm seeing, for example:

NU1605: Detected package downgrade: DiscUtils.Btrfs from 0.16.0-alpha0020 to 0.16.0-alpha0017. Reference the package directly from the project to select a different version.

MultiExtractor.Tests -> Microsoft.CST.MultiExtractor -> DiscUtils 0.16.0-alpha0020 -> DiscUtils.Btrfs (>= 0.16.0-alpha0020)

MultiExtractor.Tests -> DiscUtils.Btrfs (>= 0.15.1-ci0002)

Initially I thought the downgrade was due to unavailability of the 0.16.0-alpha0020 package, but after a bit more research it looks like a dependency resolution conflict.
https://docs.microsoft.com/en-us/nuget/concepts/dependency-resolution#nearest-wins

Problem is, I don't see where the package reference for DiscUtils.Btrfs (>= 0.15.1-ci0002) is defined anywhere within MultiExtractor.Test.csproj.

@gfs
Copy link
Contributor Author

gfs commented Jun 3, 2020 via email

@daalcant
Copy link
Contributor

daalcant commented Jun 3, 2020

Working to isolate a potential fix for this from a test branch

@daalcant
Copy link
Contributor

daalcant commented Jun 3, 2020

@gfs This appears to be in good shape now. I'll work the package renaming updates into another branch.

@gfs gfs merged commit 06af9ec into master Jun 3, 2020
@gfs gfs deleted the gfs/UpdateDiscUtils branch June 3, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants