Added toJson to FindPackageSquatResult #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a unit test as well.
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run OSS Gadget |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I fixed the pipeline issue for forks. This seems fine. |
…Result from a json string.
|
@gfs I added a FromJsonString as well, otherwise I think this should be good. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our project, we need to be able to store the squat results in cosmos, which we are doing as a string.
Having a
toJsonmethod in theFindPackageSquatResultwould be helpful. We could do it just on our side, but I thought it made sense to have in the OSSGadget project as well.Could be
toStringinstead oftoJsonif you think that's appropriate, the general premise is the same.Also now includes a
FromJsonStringto construct aFindPackageSquatResultfrom a json string.