Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added toJson to FindPackageSquatResult #300

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

jpinz
Copy link
Member

@jpinz jpinz commented Jan 25, 2022

For our project, we need to be able to store the squat results in cosmos, which we are doing as a string.
Having a toJson method in the FindPackageSquatResult would be helpful. We could do it just on our side, but I thought it made sense to have in the OSSGadget project as well.
Could be toString instead of toJson if you think that's appropriate, the general premise is the same.
Also now includes a FromJsonString to construct a FindPackageSquatResult from a json string.

@gfs
Copy link
Contributor

gfs commented Jan 25, 2022

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@gfs
Copy link
Contributor

gfs commented Jan 25, 2022

/azp run OSS Gadget

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@gfs
Copy link
Contributor

gfs commented Jan 25, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gfs
Copy link
Contributor

gfs commented Jan 25, 2022

I fixed the pipeline issue for forks. This seems fine.

@jpinz
Copy link
Member Author

jpinz commented Jan 25, 2022

@gfs I added a FromJsonString as well, otherwise I think this should be good.

@gfs
Copy link
Contributor

gfs commented Jan 25, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gfs gfs merged commit 55078cf into microsoft:main Jan 26, 2022
@jpinz jpinz deleted the jupinzer/squat_results_string branch March 9, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants