Update squat logic to address bugs. #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s causing problems and usually doesn't catch squats. Squats that would be caught by it are also caught by the prefix or suffix mutator. Overrode the SeparatorChangedMutator for PyPi as PyPi considers - and _ to be the same character. So just removed _ from the list. Fixed issues with the DuplicatorMutator that was giving the original name back as a mutated one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SeparatorRemovedMutatorfrom the list ofBaseMutatorsas it was causing problems and usually doesn't catch squats. Squats that would be caught by it are also caught by the prefix or suffix mutator.SeparatorChangedMutatorfor PyPi as PyPi considers-and_to be the same character. So just removed_from the list. There might be a better way of doing this, but I haven't thought of one yet.DuplicatorMutatorthat was giving the original name back as a mutated one.