Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape @s in namespaces in OSS-Health Tool #434

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Escape @s in namespaces in OSS-Health Tool #434

merged 1 commit into from
Jun 28, 2023

Conversation

gfs
Copy link
Contributor

@gfs gfs commented Jun 28, 2023

Small refactor to move the escape method to a helper method on the OSSGadget base class so ti can be called from any CLI as needed.

Fix #418

Small refactor to move the escape method to a helper method on the OSSGadget base class so ti can be called from any CLI as needed.
@pmalmsten
Copy link
Contributor

I wonder if there is a more central place that this transform could be done across all CLI tools? I'm not very familiar with how CLI argument parsing is done for OSSGadget - I wonder if there is any place there where we might be able to model a Package URL as a type of value (along the lines of integer vs string vs bool etc.), and put this transform there, so that any CLI tool that defines a Package URL type input value would get this parsing behavior automatically?

@gfs gfs merged commit d2c21b9 into main Jun 28, 2023
@gfs gfs deleted the gfs/#418 branch June 28, 2023 18:15
@gfs
Copy link
Contributor Author

gfs commented Jun 28, 2023

@pmalmsten I think that would be a better approach, but I'm not sure there's an obvious place to put that. It should be particularly possible for anything that takes just a Purl but for any clis that take multiple arguments it becomes more difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osshealth: NPM purl convention is incomplete, excludes most packages
2 participants