Add cache expiration for HttpCache entries. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
morended
commented
Jul 24, 2023
morended
commented
- Set cache entry size to the content length of the http response received.
- Set cache expiration for a cache entry.
- Set different cache keys for jsonDoc cache entry and http string response cache entry
pmalmsten
approved these changes
Jul 24, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpinz
approved these changes
Jul 25, 2023
| MemoryCacheEntryOptions mce = new() { Size = contentLength }; | ||
| MemoryCacheEntryOptions mce = new() { | ||
| Size = contentLength, | ||
| AbsoluteExpirationRelativeToNow = TimeSpan.FromMinutes(30), |
There was a problem hiding this comment.
nit: do we want to make this configurable?
There was a problem hiding this comment.
The reason we set it to 30 minutes is the OSSGadget code is executed by exe tools whose run time is low. Hence 30 minutes should be sufficient. But we taken totally make it configurable if needed in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.