-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌵 Olive kv_cache_config under io_config #1121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guotuofeng
reviewed
Apr 28, 2024
guotuofeng
reviewed
Apr 28, 2024
guotuofeng
reviewed
Apr 28, 2024
guotuofeng
reviewed
Apr 28, 2024
guotuofeng
reviewed
Apr 28, 2024
guotuofeng
reviewed
Apr 28, 2024
guotuofeng
previously requested changes
Apr 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better allow specify the kv cache if user would like keep using io_config function.
guotuofeng
reviewed
Apr 28, 2024
guotuofeng
reviewed
Apr 28, 2024
guotuofeng
reviewed
Apr 28, 2024
guotuofeng
reviewed
Apr 28, 2024
guotuofeng
reviewed
Apr 29, 2024
trajepl
force-pushed
the
jiapli/built_in_kv_config
branch
from
April 29, 2024 09:33
50525a7
to
2723840
Compare
jambayk
changed the title
🌵 Olive kv_cahe_config under io_config
🌵 Olive kv_cache_config under io_config
May 3, 2024
…/built_in_kv_config
guotuofeng
approved these changes
May 7, 2024
6 tasks
DavitGrigoryan132
pushed a commit
to DavitGrigoryan132/Olive
that referenced
this pull request
Aug 14, 2024
## Describe your changes 1. Add the option of kv_cache_config in io_config: - kv_cache_config: None or False, will not enable kv cache - kv_cahce_config: True or dict, will generate related kv_cache input based on existed io_config and model attributes. - Suggest to set True for huggingface transformer models - Suggest to set dict for non-huggingface models 2. Update phi2/llama2 example by removing io_config/dummy_inputs_func from user_scirpts and config json. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review
lintrunner -a
(Optional) Issue link