Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeql: fix global variable warning #1128

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Codeql: fix global variable warning #1128

merged 2 commits into from
Apr 30, 2024

Conversation

guotuofeng
Copy link
Collaborator

@guotuofeng guotuofeng commented Apr 30, 2024

Describe your changes

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

@guotuofeng guotuofeng changed the title Codeql: try to fix global variable warning Codeql: fix global variable warning Apr 30, 2024
@guotuofeng guotuofeng merged commit 8623897 into main Apr 30, 2024
35 checks passed
@guotuofeng guotuofeng deleted the myguo/retry_global branch April 30, 2024 08:46
DavitGrigoryan132 pushed a commit to DavitGrigoryan132/Olive that referenced this pull request Aug 14, 2024
## Describe your changes
* Fix https://github.com/microsoft/Olive/security/code-scanning/10629
## Checklist before requesting a review
- [ ] Add unit tests for this change.
- [ ] Make sure all tests can pass.
- [ ] Update documents if necessary.
- [ ] Lint and apply fixes to your code by running `lintrunner -a`
- [ ] Is this a user-facing change? If yes, give a description of this
change to be included in the release notes.
- [ ] Is this PR including examples changes? If yes, please remember to
update [example
documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md)
in a follow-up PR.

## (Optional) Issue link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants