OnnxFloatToFloat16: Use ort float16 converter
#1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jambayk
changed the title
OnnxFloatToFloat16: use ort float16 converter, OrtTransformersOptimization: warning for phi torchscript model
jambayk
changed the title
devang-ml
reviewed
May 2, 2024
|
Converting to draft. Will revert warning changes. |
jambayk
changed the title
OnnxFloatToFloat16: Use ort float16 converter
devang-ml
approved these changes
May 3, 2024
DavitGrigoryan132
pushed a commit
to DavitGrigoryan132/Olive
that referenced
this pull request
Aug 14, 2024
## Describe your changes - `onnxconverter-common`'s float16 converter tool is not regularly maintained and it also cannot large models (>2GB). Use the float16 converted from onnxruntime which is a modified version of the previous tool and has more features. - Added unit test for pass. ## Checklist before requesting a review - [x] Add unit tests for this change. - [x] Make sure all tests can pass. - [x] Update documents if necessary. - [x] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
onnxconverter-common's float16 converter tool is not regularly maintained and it also cannot large models (>2GB). Use the float16 converted from onnxruntime which is a modified version of the previous tool and has more features.Checklist before requesting a review
lintrunner -a(Optional) Issue link